Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unweighted temporal averages to not require bounds #579

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Update unweighted temporal averages to not require bounds #579

merged 1 commit into from
Jan 2, 2024

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Dec 8, 2023 •
edited
Loading

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

Update unweighted temporal averages to not require bounds
4026035 
- Time bounds are required for generating weights for weighted averages
@tomvothecoder tomvothecoder self-assigned this Dec 8, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6238148) 100.00% compared to head (4026035) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #579   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1602      1602           
=========================================
  Hits          1602      1602

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomvothecoder
Copy link
Collaborator Author

Hey @pochedls, this simple PR is ready for review whenever you're free. Unit tests are still passing and the script you pasted in #437 works on my end.

@tomvothecoder tomvothecoder added the type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 8, 2023
pochedls
pochedls approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@pochedls pochedls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long...this refactor + bug fix looks good to me.

@tomvothecoder
Copy link
Collaborator Author

@pochedls No problem, there was no rush here. Thanks for the review!

@tomvothecoder tomvothecoder merged commit fb624bd into main Jan 2, 2024
@tomvothecoder tomvothecoder deleted the bug/437-unweighted-no-weights branch January 2, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pochedls pochedls pochedls approved these changes

Assignees

@tomvothecoder tomvothecoder

Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
xCDAT Development
Status: Done
Milestone
FY24Q1 (10/01/23 - 12/31/23)
Development

Successfully merging this pull request may close these issues.

[Bug]: (Un-weighted) temporal averaging probably doesn't need bounds
2 participants
@tomvothecoder @pochedls